manuel manuel
  • Joined on 2021-05-20
manuel commented on pull request JOJ/JOJ3#60 2024-10-18 14:45:22 +08:00
fix/forbidden (#58)

what if you add test1/test2/test.c?

suppose you have .gitignore at repo root, test1 dir is allowed and can contain *.c. what is happening if you create test1/test2/test.c?

do…

manuel commented on issue JOJ/JOJ3#62 2024-10-18 10:41:44 +08:00
Healthchecker cannot properly catch the error for different hash

add more debug logs before calling the hash check, during, and after. then send the link of the gitea action

manuel commented on issue JOJ/JOJ3#62 2024-10-18 10:09:14 +08:00
Healthchecker cannot properly catch the error for different hash

.gitignore is also kind of involved in the process. what about a readonly readme or any other "neutral" file?

manuel commented on issue JOJ/JOJ3#62 2024-10-18 09:39:25 +08:00
Healthchecker cannot properly catch the error for different hash

@allen_wr testing file change on push.yaml might not be the easiest test as this file is involved itself in the process. maybe first start with a readonly Readme, then a .gitignore, after…

manuel commented on issue JOJ/JOJ3#62 2024-10-18 08:24:01 +08:00
Healthchecker cannot properly catch the error for different hash

The hash of which file is wrong in the first issue?

looks like /home/hydraallen/Desktop/Github/Others/hteam-00/.gitea/workflows/push.yaml (so push.yaml on server)

we probably don't…

manuel commented on pull request JOJ/JOJ3#60 2024-10-17 21:00:01 +08:00
fix/forbidden (#58)

what if you add test1/test2/test.c?

do we need to have a gitignore in each in each folder?

manuel commented on pull request JOJ/JOJ3#60 2024-10-17 19:19:15 +08:00
fix/forbidden (#58)

can anyone think about some more tricky cases.

  • try a forbidden dir which has an allowed file inside
  • try a .DB_Store in a subdir

in 100 we need students to list their "allowed…

manuel commented on pull request JOJ/JOJ3#60 2024-10-17 16:58:24 +08:00
fix/forbidden (#58)

with JOJ3 they must have an immutable gitignore or the server will quickly become a massive mess... caught a student who wanted to see what happened if he pushd a movie... repo was 2.8GB :/

manuel commented on issue JOJ/JOJ3#61 2024-10-17 15:44:48 +08:00
healthcheck not working

where are messages displayed? could it be a parser issue? (not configured properly)

manuel commented on pull request JOJ/JOJ3#49 2024-10-08 10:57:55 +08:00
feat: get release tag from msg scope

Is this the behavior you want @manuel 8af5aac645/pkg/healthcheck/tag.go

it looks like it! lets see how in…